Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to core20 #61

Merged
merged 13 commits into from
Aug 26, 2022
Merged

Updated to core20 #61

merged 13 commits into from
Aug 26, 2022

Conversation

kenvandine
Copy link
Collaborator

@kenvandine kenvandine commented Dec 6, 2021

This branch updates to core20, still a WIP. Fixes #53

env.sh Outdated Show resolved Hide resolved
@jpnurmi
Copy link
Contributor

jpnurmi commented Feb 14, 2022

The analysis fails because /lib/x86_64-linux-gnu/libgcc_s.so.1 is linked. I thought it was something implicitly pulled in by wrong libepoxy.so but that doesn't seem to be the case.

18.04:

$ apt-file search /lib/x86_64-linux-gnu/libgcc_s.so.1
libgcc1: /lib/x86_64-linux-gnu/libgcc_s.so.1

20.04:

$ apt-file search /lib/x86_64-linux-gnu/libgcc_s.so.1
libgcc-s1: /lib/x86_64-linux-gnu/libgcc_s.so.1

We could try staging libgcc-s1 next?

@ikbendewilliam
Copy link

Hi, thank you for your work! Do you have an ETA when this will be merged or is there still work to be done? I need this to build a snap that uses the just_audio_libwinmedia plugin, see also libwinmedia#8.
This is for a project for the flutter hack challenge with 10 more days to deadline.
Or can I install a snap from the working branch? (I'm not very familiar with snap).
If neither is possible it's fine, but I thought I'll at least ask 😁

@kenvandine
Copy link
Collaborator Author

kenvandine commented Mar 4, 2022

Hi, thank you for your work! Do you have an ETA when this will be merged or is there still work to be done? I need this to build a snap that uses the just_audio_libwinmedia plugin, see also libwinmedia#8. This is for a project for the flutter hack challenge with 10 more days to deadline. Or can I install a snap from the working branch? (I'm not very familiar with snap). If neither is possible it's fine, but I thought I'll at least ask grin

@ikbendewilliam Here's an example of building a snap based on core20 using flutter.

I'd love to see what you come up with and am also happy to help you if you have questions while creating the snap. Feel free to contact me!

@ikbendewilliam
Copy link

@ikbendewilliam Here's an example of building a snap based on core20 using flutter.

@kenvandine do you have a link perhaps, it seems to be missing? Thank you for your help!

This is the project I'm trying to build: GitHub Repo, Try it out on web. Linux is the final platform that is not supported through a store.

(Microsoft rejected it because it's not a "game" according to them 😅 but that's another problem)

@kenvandine
Copy link
Collaborator Author

@ikbendewilliam Here's an example of building a snap based on core20 using flutter.

@kenvandine do you have a link perhaps, it seems to be missing? Thank you for your help!

This is the project I'm trying to build: GitHub Repo, Try it out on web. Linux is the final platform that is not supported through a store.

(Microsoft rejected it because it's not a "game" according to them sweat_smile but that's another problem)

@ikbendewilliam sorry, mark down formatting issue. I've edited my comment with the link

@Gustl22
Copy link

Gustl22 commented Apr 1, 2022

Any progress on this? Unfortunately I'm not familiar with creating my own snaps, and I used snapcraft --use-lxd option, which results in error: unable to contact snap store, and I do not have enough available space for multipass, see this.

Is there any reason to be still WIP? I would really appreciate if this could be released soon ;D

@zh4ngx
Copy link

zh4ngx commented May 18, 2022

Eagerly awaiting this as well :)

@chirag729
Copy link

@kenvandine Any progress on this issue?

@kenvandine
Copy link
Collaborator Author

I'm not sure when we're going to rebase on core20 or core22. Flutter is intended to be available on 18.04 and there's a pretty easy way to build a snap based on core20 without the need for the flutter snap itself to be core20. Have you run into issues building your snap based on core20 following the example I provided?

@zh4ngx
Copy link

zh4ngx commented Jun 15, 2022

@kenvandine I believe the issue is that the newest version of Flutter requires it in order to run flutter desktop for linux in #53

See the latest comment

@chirag729
Copy link

Yes I tried the workaround but ran into an error which I've been trying to solve without much luck.

Failed to generate snap metadata: The specified command 'omnichess_app' defined in the app 'omnichess' does not exist.

I've debugged the snap and verified that omnichess_app exists so not sure why it's complaining.

I've had this working for a couple of months before I upgraded the audioplayers package to 1.0.0 which uses a function only available in cmake 3.11

@chirag729
Copy link

Another reason for updating is for local development. I can no longer use the snap to install flutter on my dev machine because the version of cmake it comes with is too old. Certain packages require higher versions so I'm forced to install manually which is not an ideal situation. I'd rather be using the exact same flutter install as my production apps as there are, strangely enough, subtle behavioural differences between the two

@kenvandine kenvandine changed the title WIP: Updated to core20 Updated to core20 Jun 17, 2022
@kenvandine
Copy link
Collaborator Author

I've published the core20 build to the edge/core20 channel for further testing. To test this:

snap refresh --channel=edge/core20 flutter

Any testing would be appreciated!

@zh4ngx
Copy link

zh4ngx commented Jun 22, 2022

I am now able to run Linux desktop on Flutter 3.0 right from the snap. Thanks!

@MateusAmin
Copy link

MateusAmin commented Aug 23, 2022

@kenvandine

Currently, the latest/edge/core20 channel is on core18 and has cmake 3.10.2.

@kenvandine
Copy link
Collaborator Author

I've reopened the core20 branch, you should get it automatically if you were tracking latest/edge/core20

@jpnurmi now that we've fixed the test infra, what do you think about merging this?

@MateusAmin
Copy link

@kenvandine

Thanks!

@jpnurmi
Copy link
Contributor

jpnurmi commented Aug 23, 2022

@jpnurmi now that we've fixed the test infra, what do you think about merging this?

I can't think of any reason why not. Do you have any particular concerns?

@kenvandine
Copy link
Collaborator Author

kenvandine commented Aug 23, 2022 via email

@kenvandine kenvandine merged commit e14079f into main Aug 26, 2022
@zh4ngx
Copy link

zh4ngx commented Sep 16, 2022

🥳

@gsouf
Copy link

gsouf commented Sep 20, 2022

I tested core 20 as per above instructions. My app work like a charm, nothing to report. Looking forward to see it as the default

@zh4ngx
Copy link

zh4ngx commented Oct 19, 2022

Will this make it into the stable branch on snap? https://snapcraft.io/flutter looks like stable is still pointing to a commit in May

@kenvandine
Copy link
Collaborator Author

This has been promoted to stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snap uses an old version of CMake
8 participants