-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to core20 #61
Conversation
The analysis fails because 18.04:
20.04:
We could try staging |
Hi, thank you for your work! Do you have an ETA when this will be merged or is there still work to be done? I need this to build a snap that uses the just_audio_libwinmedia plugin, see also libwinmedia#8. |
@ikbendewilliam Here's an example of building a snap based on core20 using flutter. I'd love to see what you come up with and am also happy to help you if you have questions while creating the snap. Feel free to contact me! |
@kenvandine do you have a link perhaps, it seems to be missing? Thank you for your help! This is the project I'm trying to build: GitHub Repo, Try it out on web. Linux is the final platform that is not supported through a store. (Microsoft rejected it because it's not a "game" according to them 😅 but that's another problem) |
@ikbendewilliam sorry, mark down formatting issue. I've edited my comment with the link |
Any progress on this? Unfortunately I'm not familiar with creating my own snaps, and I used Is there any reason to be still WIP? I would really appreciate if this could be released soon ;D |
Eagerly awaiting this as well :) |
@kenvandine Any progress on this issue? |
I'm not sure when we're going to rebase on core20 or core22. Flutter is intended to be available on 18.04 and there's a pretty easy way to build a snap based on core20 without the need for the flutter snap itself to be core20. Have you run into issues building your snap based on core20 following the example I provided? |
@kenvandine I believe the issue is that the newest version of Flutter requires it in order to run flutter desktop for linux in #53 See the latest comment |
Yes I tried the workaround but ran into an error which I've been trying to solve without much luck.
I've debugged the snap and verified that omnichess_app exists so not sure why it's complaining. I've had this working for a couple of months before I upgraded the audioplayers package to 1.0.0 which uses a function only available in cmake 3.11 |
Another reason for updating is for local development. I can no longer use the snap to install flutter on my dev machine because the version of cmake it comes with is too old. Certain packages require higher versions so I'm forced to install manually which is not an ideal situation. I'd rather be using the exact same flutter install as my production apps as there are, strangely enough, subtle behavioural differences between the two |
I've published the core20 build to the edge/core20 channel for further testing. To test this: snap refresh --channel=edge/core20 flutter Any testing would be appreciated! |
I am now able to run Linux desktop on Flutter 3.0 right from the snap. Thanks! |
Currently, the latest/edge/core20 channel is on core18 and has cmake 3.10.2. |
I've reopened the core20 branch, you should get it automatically if you were tracking latest/edge/core20 @jpnurmi now that we've fixed the test infra, what do you think about merging this? |
Thanks! |
I can't think of any reason why not. Do you have any particular concerns? |
No, I think it's ready
…On Tue, Aug 23, 2022, 12:02 PM J-P Nurmi ***@***.***> wrote:
@jpnurmi <https://github.com/jpnurmi> now that we've fixed the test
infra, what do you think about merging this?
I can't think of any reason why not. Do you have any particular concerns?
—
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAANMBINZKXXEUP6UFEO4BDV2TYZFANCNFSM5JPCQ5PQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
🥳 |
I tested core 20 as per above instructions. My app work like a charm, nothing to report. Looking forward to see it as the default |
Will this make it into the stable branch on snap? https://snapcraft.io/flutter looks like stable is still pointing to a commit in May |
This has been promoted to stable. |
This branch updates to core20, still a WIP. Fixes #53