Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: list resource revisions for a package #129

Merged
merged 2 commits into from
Dec 7, 2023
Merged

feat: list resource revisions for a package #129

merged 2 commits into from
Dec 7, 2023

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Dec 6, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Requires #128
fixes #125

@lengau lengau mentioned this pull request Dec 6, 2023
Merged
3 tasks
@lengau lengau force-pushed the CRAFT-2329/list-resource-revisions branch from 2130d01 to ba6cec3 Compare December 6, 2023 15:42
@lengau lengau requested review from tigarmo, mr-cal and syu-w December 6, 2023 15:43
@lengau lengau requested a review from tigarmo December 6, 2023 19:58
tigarmo
tigarmo approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well I didn't mean to affect the PR! I thought it might be worth a mention so we'd bring up the topic of "strictness" when handling store data at some point
either way, LGTM

@lengau lengau merged commit 47e8458 into main Dec 7, 2023
@lengau lengau deleted the CRAFT-2329/list-resource-revisions branch December 7, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigarmo tigarmo tigarmo approved these changes

@mr-cal mr-cal mr-cal approved these changes

@syu-w syu-w Awaiting requested review from syu-w

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get and list resource revisions
3 participants
@lengau @tigarmo @mr-cal