feat: bump chisel.yaml format version to "chisel-v2" #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6bf6d46.
This commit adds the functionalities to add public keys to validate
archive InRelease file signatures. Instead of downloading the "Release"
files for different suites, download the signed "InRelease" file and
validate the signature with the provided key(s).
This commit extends the chisel release with public keys definitions.
They are stored in ASCII armored format in the top-level public-keys
property by name. And they are referenced by name in the public-keys
list property in archive definitions. An example of the extended chisel
release file is at the bottom.
Example chisel.yaml:
format: chisel-v1
archives:
ubuntu:
version: 22.04
components: [main, universe]
suites: [jammy, jammy-updates, jammy-security]
public-keys: [ubuntu]
ubuntu-fips:
version: 22.04
pro: fips
components: [main]
suites: [jammy]
public-keys: [ubuntu-fips]
ubuntu-fips-updates:
version: 22.04
pro: fips-updates
components: [main]
suites: [jammy]
public-keys: [ubuntu-fips]
public-keys:
ubuntu:
id: C2B15A6A7FCD95FD
armor: |
-----BEGIN PGP PUBLIC KEY BLOCK-----
mQINBFzZxGABEADSWmX0+K//0cosKPyr5m1ewmwWKjRo/KBPTyR8icHhbBWfFd8T
DtYggvQHPU0YnKRcWits0et8JqSgZttNa28s7SaSUTBzfgzFJZgULAi/4i8u8TUj
+KH2zSoUX55NKC9aozba1cR66jM6O/BHXK5YoZzTpmiY1AHlIWAJ9s6cCClhnYMR
...
E+SWDGxtgwixyPziL56UavL/eeYJWeS/WqvGzZzsAtgSujFVLKWyUaRi0NvYW3h/
I50Tzj0Pkm8GtgvP2UqAWvy+iRpeUQ2ji0Nc
=j6+P
-----END PGP PUBLIC KEY BLOCK-----
ubuntu-fips:
id: E173597E2CAB05C1
armor: |
-----BEGIN PGP PUBLIC KEY BLOCK-----
mQINBE+tgXgBEADfiL1KNFHT4H4Dw0OR9LemR8ebsFl+b9E44IpGhgWYDufj0gaM
/UJ1Ti3bHfRT39VVZ6cv1P4mQy0bnAKFbYz/wo+GhzjBWtn6dThYv7n+KL8bptSC
Xgg1a6en8dCCIA/pwtS2Ut/g4Eu6Z467dvYNlMgCqvg+prKIrXf5ibio48j3AFvd
...
mguPI1KLfnVnXnsT5JYMbG2DCLHI/OIvnpRq8v955glZ5L9aq8bNnOwC2BK6MVUs
pbJRpGLQ29hbeH8jnRPOPQ+Sbwa2C8/ZSoBa/L6JGl5RDaOLQ1w=
=6Bkw
-----END PGP PUBLIC KEY BLOCK-----
This commit introduces a new chisel-release yaml format named "chisel-v2". The major changes in this format is the introduction of the "public-keys" field, which is used in archive definitions to verify archive InRelease files.
This reverts commit 0995608.
This commit introduces a new chisel-release yaml format named "chisel-v2". The major changes in this format is the introduction of the "public-keys" field, which is used in archive definitions to verify archive InRelease files.
b7f5b28 to
eeab8d1
Compare
cjdcordeiro
requested changes
Dec 14, 2023
| } | ||
|
|
||
| const yamlReleaseFormat = "chisel-v1" | ||
| const yamlReleaseFormat = "chisel-v2" |
There was a problem hiding this comment.
My understanding is that we should support both chisel-v1 and chisel-v2 for a while. This will allows for us to release v0.9.0 with support for chisel-v1, but already with GPG support, such that later, when we migrate to chisel-v2, v0.9.0 doesn't break. Then in the future we can remove chisel-v1 as it becomes redundant since it will no longer be in the chisel-releases
|
As a side note, before merging, please consider the plan described in #106 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the format changes in #106, the format version needs to be increases to provide users with a good error message that highlights this change in format instead of a the fact that a field is missing.
This PR depends on #106.