Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc_ice_hook: Disable buggy pylint check #202

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

schopin-pro
Copy link
Contributor

This line bugs out once in a while in pylint ever since we enabled parallelism. Since the parallel gains are substantial, let's just disable the check there.

@schopin-pro schopin-pro requested a review from bdrung July 12, 2023 12:46
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #202 (b7df2ff) into main (71ba06f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files          91       91           
  Lines       18526    18526           
=======================================
  Hits        15314    15314           
  Misses       3212     3212           
Impacted Files Coverage Δ
data/gcc_ice_hook 72.22% <ø> (ø)

Copy link
Collaborator

@bdrung bdrung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an explanation comment that this is a false positive when using pylint with parallel option? Bonus points for linking an upstream bug report.

data/gcc_ice_hook Outdated Show resolved Hide resolved
data/gcc_ice_hook Outdated Show resolved Hide resolved
@schopin-pro schopin-pro force-pushed the fixup-parallel branch 2 times, most recently from 11cdd6f to 2e75f2a Compare July 12, 2023 14:47
This line bugs out once in a while in pylint ever since we enabled
parallelism. Since the parallel gains are substantial, let's just
disable the check there.

See pylint-dev/pylint#7710
@schopin-pro schopin-pro requested a review from bdrung July 12, 2023 14:56
@bdrung bdrung changed the title gcc_ice_hook: Disable buggy (racy?) pylint check gcc_ice_hook: Disable buggy pylint check Jul 12, 2023
Copy link
Collaborator

@bdrung bdrung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL to use disable-next. I'll merge once the tests are green.

@bdrung bdrung merged commit b4e81f4 into canonical:main Jul 12, 2023
@schopin-pro schopin-pro deleted the fixup-parallel branch February 13, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants