Skip to content

Commit

Permalink
Stop using TaliskerRequestsTransport
Browse files Browse the repository at this point in the history
At least for now stop using the TaliskerRequestsTransport.

In practice, for flask apps it was not used in the apps/workers because
FlaskSentry was explicitly setting a None 'transport' in the client
kwargs.

This change makes sure that the same default raven (threaded) transport
is used by logging in the main process. This will mitigate the deadlocks
described in
prometheus/client_python#1076 (comment)
because there will be no prometheus instrumentation for sentry requests.
  • Loading branch information
suligap committed Dec 4, 2024
1 parent 91949e2 commit a939968
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions talisker/sentry.py
Original file line number Diff line number Diff line change
Expand Up @@ -317,9 +317,6 @@ def ensure_talisker_config(kwargs):
processors = set(kwargs.get('processors') or [])
kwargs['processors'] = list(default_processors | processors)

if 'transport' not in kwargs:
kwargs['transport'] = TaliskerRequestsTransport

# note: style clash - sentry client api is 'sanitize_keys'
sanitise_keys = kwargs.get('sanitize_keys', [])
if sanitise_keys is None: # flask integration explicitly sets None
Expand Down

0 comments on commit a939968

Please sign in to comment.