Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment deprecation warnings #376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

imaustink
Copy link
Contributor

These were commented out because of issues down steam caused by tests being dependent on can-log/dev.warn. These have since been addressed with can-test-helpers.

@phillipskevin
Copy link
Contributor

Did all of the modules in canjs/canjs get updated to use the new modules?

@imaustink
Copy link
Contributor Author

It would appear not. I found references to the following modules after running the canjs tests locally with this branch of can-util:

js/assign/assign
js/dev/dev
js/log/log
js/cid-map/cid-map
js/cid-set/cid-set
js/global/global

I will write a cod mod for these and update everything before merging this.

@imaustink imaustink force-pushed the uncomment-deprecation-warnings branch from 9584100 to 89fb349 Compare November 16, 2017 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants