Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I get feedback when source or target attribute of <camunda:in/> element has trailing whitespace #720

Closed
2 tasks
romansmirnov opened this issue Jan 22, 2018 · 4 comments
Labels
Camunda 7 Flags an issue as related to Camunda Automation Platform 7 channel:support
Milestone

Comments

@romansmirnov
Copy link
Member

romansmirnov commented Jan 22, 2018

Context:

  • BPMN Properties Panel

Expected behavior:

  • Show a validation error message on whitespace in source or target
  • Allow whitespace in source expression

Cf. SUPPORT-3961

@nikku
Copy link
Member

nikku commented Jan 22, 2018

Why not simply remove trailing or leading whitespace?

Update: This is exactly what the customer suggests, too.

@nikku nikku added this to the M18 milestone Jan 31, 2018
@nikku nikku added the ready Ready to be worked on label Feb 7, 2018
@nikku nikku modified the milestones: M18, M19 Feb 26, 2018
@nikku nikku added backlog Queued in backlog ready Ready to be worked on and removed ready Ready to be worked on backlog Queued in backlog labels Feb 26, 2018
@nikku nikku added backlog Queued in backlog and removed ready Ready to be worked on labels Mar 6, 2018
@nikku nikku modified the milestones: M19, M20 Mar 23, 2018
@nikku nikku added ready Ready to be worked on Camunda 7 Flags an issue as related to Camunda Automation Platform 7 and removed backlog Queued in backlog labels Apr 5, 2018
@philippfromme philippfromme added in progress Currently worked on and removed ready Ready to be worked on labels Apr 10, 2018
philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Apr 10, 2018
@philippfromme philippfromme added needs review Review pending and removed in progress Currently worked on labels Apr 10, 2018
@philippfromme philippfromme assigned nikku and unassigned philippfromme Apr 10, 2018
philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Apr 11, 2018
philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Apr 11, 2018
@nikku
Copy link
Member

nikku commented Apr 11, 2018

We've decided to validate instead of automatically trimming whitespace, as the later was too much magic.

@nikku
Copy link
Member

nikku commented Apr 11, 2018

Fails locally and on CI.

nikku pushed a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Apr 11, 2018
@nikku
Copy link
Member

nikku commented Apr 11, 2018

I've fixed the minor issue that made the stuff fail on CI.

Further change is needed though:

  • We must not validate source expression, as it may contain whitespace: foo(a + b)
  • We must validate source / target, these are variables that must not contain whitespace: abCD

I've updated the issue description accordingly.

@nikku nikku assigned nikku and philippfromme and unassigned nikku Apr 11, 2018
@nikku nikku added ready Ready to be worked on and removed needs review Review pending labels Apr 11, 2018
philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Apr 11, 2018
@philippfromme philippfromme added needs review Review pending and removed ready Ready to be worked on labels Apr 11, 2018
@ghost ghost removed the needs review Review pending label Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Camunda 7 Flags an issue as related to Camunda Automation Platform 7 channel:support
Projects
None yet
Development

No branches or pull requests

4 participants