Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit "Decision ID" label for the called decision #2725

Closed
barmac opened this issue Feb 3, 2022 · 3 comments · Fixed by bpmn-io/bpmn-js-properties-panel#681
Closed

Use explicit "Decision ID" label for the called decision #2725

barmac opened this issue Feb 3, 2022 · 3 comments · Fixed by bpmn-io/bpmn-js-properties-panel#681
Assignees
@Skaiir
Labels
Camunda 8 Flags an issue as related to Camunda 8 enhancement New feature or request spring cleaning Could be cleaned up one day
Milestone
M54

Comments

@barmac
Copy link
Collaborator

barmac commented Feb 3, 2022

Is your feature request related to a problem? Please describe.

The current "ID" label is cryptic.

image

Describe the solution you'd like

Let's make it explicit that we expect Decision ID.

Describe alternatives you've considered

Leave it as is.

Additional context

Popped up during a kick-off meeting. Requested by @korthout
@barmac barmac added enhancement New feature or request Camunda 8 Flags an issue as related to Camunda 8 labels Feb 3, 2022
@andreasgeier
Copy link

Although I believe it is a common pattern in the panel that the group states the scope and the labels within are related and should be short and concise (e.g. group:ExtensionProperty > label:Name), I would agree that we can make an exception for our main entities and write Decision ID and Form reference etc.

@korthout
Copy link
Member

korthout commented Feb 4, 2022

An additional argument is that it would align with Call Activity's Process ID.

@pinussilvestrus pinussilvestrus added backlog Queued in backlog spring cleaning Could be cleaned up one day labels Feb 8, 2022
@Skaiir Skaiir self-assigned this May 16, 2022
@Skaiir Skaiir added ready Ready to be worked on and removed backlog Queued in backlog labels May 16, 2022
@Skaiir Skaiir mentioned this issue May 16, 2022
Merged
@Skaiir Skaiir added fixed upstream Requires integration of upstream change and removed ready Ready to be worked on labels May 16, 2022
@MaxTru MaxTru added this to the M54 milestone May 31, 2022
Skaiir added a commit that referenced this issue Jul 8, 2022
@Skaiir
deps: bump camunda-bpmn-js to 0.15.0
e77fc5d 
transitive deps:

`bpmn-js-properties-panel@0.15.1`
Closes #2989, #3003, #2725, #2920

`properties-panel@0.15.0`
Closes #2990

`bpmn-js@9.3.1`
Closes #2993
@Skaiir
Copy link
Contributor

Skaiir commented Jul 8, 2022 •
edited
Loading

Closed via bc8b748

@Skaiir Skaiir closed this as completed Jul 8, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Jul 8, 2022
Skaiir added a commit that referenced this issue Jul 8, 2022
@Skaiir
deps: bump camunda-bpmn-js to 0.15.0
bc8b748 
transitive deps:

`bpmn-js-properties-panel@0.15.1`
Closes #2989, #3003, #2725, #2920

`properties-panel@0.15.0`
Closes #2990

`bpmn-js@9.3.1`
Closes #2993, #2859
@Skaiir Skaiir mentioned this issue Jul 8, 2022
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skaiir Skaiir

Labels
Camunda 8 Flags an issue as related to Camunda 8 enhancement New feature or request spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
M54
Development

Successfully merging a pull request may close this issue.

fix: called decision decision ID made explicit bpmn-io/bpmn-js-properties-panel
6 participants
@andreasgeier @korthout @pinussilvestrus @Skaiir @barmac @MaxTru