-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting corpus and crashes dirs in cargo bolero test #86
Conversation
bb3534a
to
7f897a4
Compare
Also make libfuzzer consider all artifacts as corpus items to go through on startup as a drive-by fix
7f897a4
to
31fcb3d
Compare
As drive-by fixes :
|
Hmm the remaining errors seem probably unrelated to this change, but I'm not sure how to fix them — I can say that with my real-world test targets things seem to work properly on my machine. (Oh and obviously |
Probably bumping the MSRV further would fix things, as stable tests pass properly in CI? But I'm not sure that's something you're willing to do, so I'm not adding that to the PR right now :) |
The MSRV policy is a rolling 6+ month window so I'll need to figure out another fix for that. But the corpus override seems reasonable to me. |
Hmm ok thanks! What's weird is I think I had already hit this exact issue with cargo-fuzz when the version of cargo-fuzz and the version of rustc didn't have the same LLVM version, but I had seemed to notice that cargo-bolero, for a reason I'm not sure of, didn't hit this issue. My guess had been that cargo-bolero did LLVM version autodetection, but I'm not sure if it's actually true given I'm seeing this now :/ |
AFAICT rust 1.57.0 was released more than 6 months ago (Dec 2, 2021), so hopefully this would be good to go? :) |
It should be now! |
Fixes #84