Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting corpus and crashes dirs in cargo bolero test #86

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

Ekleog
Copy link
Contributor

@Ekleog Ekleog commented Jul 18, 2022

Fixes #84

Ekleog added 2 commits July 18, 2022 21:14
Also make libfuzzer consider all artifacts as corpus items to go through
on startup as a drive-by fix
@Ekleog Ekleog force-pushed the allow-setting-corpus-dirs branch from 7f897a4 to 31fcb3d Compare July 18, 2022 19:16
@Ekleog
Copy link
Contributor Author

Ekleog commented Jul 18, 2022

As drive-by fixes :

  • Make libfuzzer also consider all artifacts as corpus items, to be scanned on startup
  • Bump rust-toolchain to 1.57 because the tests initially failed in CI, due to a dependency requiring at least 1.57

@Ekleog
Copy link
Contributor Author

Ekleog commented Jul 18, 2022

Hmm the remaining errors seem probably unrelated to this change, but I'm not sure how to fix them — I can say that with my real-world test targets things seem to work properly on my machine.

(Oh and obviously cargo test passes here)

@Ekleog
Copy link
Contributor Author

Ekleog commented Jul 18, 2022

Probably bumping the MSRV further would fix things, as stable tests pass properly in CI? But I'm not sure that's something you're willing to do, so I'm not adding that to the PR right now :)

@camshaft
Copy link
Owner

The MSRV policy is a rolling 6+ month window so I'll need to figure out another fix for that. But the corpus override seems reasonable to me.

@Ekleog
Copy link
Contributor Author

Ekleog commented Jul 20, 2022

Hmm ok thanks!

What's weird is I think I had already hit this exact issue with cargo-fuzz when the version of cargo-fuzz and the version of rustc didn't have the same LLVM version, but I had seemed to notice that cargo-bolero, for a reason I'm not sure of, didn't hit this issue. My guess had been that cargo-bolero did LLVM version autodetection, but I'm not sure if it's actually true given I'm seeing this now :/

@Ekleog
Copy link
Contributor Author

Ekleog commented Aug 18, 2022

AFAICT rust 1.57.0 was released more than 6 months ago (Dec 2, 2021), so hopefully this would be good to go? :)

@camshaft
Copy link
Owner

It should be now!

@camshaft camshaft merged commit 2e58b59 into camshaft:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow defining the location for corpus and artifacts directories
2 participants