Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchemaBundle: remove use of Router and Templating Service in EmbeddedBroadcastService #293

Open
mreyk opened this issue Feb 1, 2017 · 0 comments
Assignees

Comments

@mreyk
Copy link

mreyk commented Feb 1, 2017

To avoid circular dependencies if this service is used in other services (twig services for example), remove the user of Router and Templating Service in EmbeddedBroadcastService.
This affects each Controller that uses the canUserPlayMultimediaObject function
https://github.com/campusdomar/PuMuKIT2/blob/master/src/Pumukit/SchemaBundle/Services/EmbeddedBroadcastService.php#L255
and the response it gives to the controllers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants