Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Reduce file reads in handlers #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vinayak-mehta
Copy link
Member

I got a 5 second improvement for a 100 page foo.pdf.

@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #89 into master will increase coverage by 0.01%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #89      +/-   ##
=========================================
+ Coverage   87.69%   87.7%   +0.01%     
=========================================
  Files          13      13              
  Lines        1511    1513       +2     
  Branches      349     349              
=========================================
+ Hits         1325    1327       +2     
  Misses        129     129              
  Partials       57      57
Impacted Files Coverage Δ
camelot/handlers.py 90.47% <90.9%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f187972...6744e05. Read the comment docs.

@bosd
Copy link
Collaborator

bosd commented Jul 14, 2023

What is the status of this pr?
Can tests be triggered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants