Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

az containerapp registry set: remove username/password if setting identity and vice versa #131

Merged
merged 1 commit into from
Jun 13, 2022
Merged

az containerapp registry set: remove username/password if setting identity and vice versa #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/containerapp/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Release History
0.3.7
++++++
* 'az containerapp env create': fixed bug where "--internal-only" didn't work
* 'az containerapp registry set': remove username/password if setting identity and vice versa

0.3.6
++++++
Expand Down
4 changes: 4 additions & 0 deletions src/containerapp/azext_containerapp/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1729,15 +1729,19 @@ def set_registry(cmd, name, resource_group_name, server, username=None, password
updating_existing_registry = True
if username:
r["username"] = username
r["identity"] = None
if password:
r["passwordSecretRef"] = store_as_secret_and_return_secret_ref(
containerapp_def["properties"]["configuration"]["secrets"],
r["username"],
r["server"],
password,
update_existing_secret=True)
r["identity"] = None
if identity:
r["identity"] = identity
r["username"] = None
r["passwordSecretRef"] = None

# If not updating existing registry, add as new registry
if not updating_existing_registry:
Expand Down