Pressure Code Reviewed #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have reviewed the pressure code, and made some changes so that no code is repeated, so that when we run the tests with the hardware, we should only have to make a change in one place.
The numbers for the states have been replaced with an enum. The compiler translates this enum into integer values, so it should work identically to how it was previously, but with some more readability.
Before this code can work, the DUMMY value at the top, where the pins for each pressurized tank need to be set to a realistic value. Along with this, the pressureFromPtval() function needs to be calibrated according to the necessary ticks to psi.