Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing swc config in RN & NM rules #843

Merged
merged 5 commits into from
Dec 30, 2024
Merged

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Dec 30, 2024

Summary

added some missing configuration to builtin:swc-loader rules:

  • - enabled loose in env options which as it turns out is different from loose in jsc options - and we need both to match the babel preset
  • - added explicit noInterop option set to false for visibility

Test plan

n/a

Copy link

changeset-bot bot commented Dec 30, 2024

🦋 Changeset detected

Latest commit: 1dede35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@callstack/repack Patch
@callstack/repack-plugin-reanimated Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Dec 30, 2024 10:34pm

@jbroma jbroma merged commit 3029ab6 into main Dec 30, 2024
5 checks passed
@jbroma jbroma deleted the fix/missing-swc-config branch December 30, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant