fix: @expo changed to expo in babel-loader config in webpack config templates

[outsung]

Summary

When using expo library or when using expo and repack,
Need to modify it to expo instead of @expo to work.

Can refer to this comment.

Test plan

[changeset-bot]

⚠️ No Changeset found

Latest commit: cf7cd39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[RafikiTiki]

Hey @outsung! First of all – thanks for your contribution!

I think the @expo regex was there for a reason – there are still some expo packages that are named @expo/package-name (for example: https://www.npmjs.com/package/@expo/vector-icons), and I think they still need to be processed by webpack. Let me ask around and see if we would like to leave the old @expo rule along with the new @expo one for backward compatibility.

[outsung]

@RafikiTiki Thanks for the confirmation!

[jbroma]

@RafikiTiki any update on this?

[RafikiTiki]

Thanks for pinging me – from my investigation, it looks like only the @expo/vector-icons package uses the @expo naming convention. I think we're good to remove it from the default webpack config since we're not using this package internally.

If anyone would want to use it, it can be added to the webpack config same as with other 3rd party packages that need to be transpiled by babel.

[jbroma]

LGTM

[jbroma]

Thanks for your contribution @outsung!