Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
no functionality change just make API consistent.
The change to https://github.com/callstack/react-native-slider/pull/649/files#diff-e1ce4a6b5a58885eafa4615c2f0835fb1561080fcbcffb2ac8ac50fd0fb3bbaa
changed the
value
parameter fromfloat
todouble
typebut the
@ReactProp
annotation still uses float. This PR changes it todefaultDouble
to be consistentdouble
type for both annotation andvalue
parameter typeOther Inconsistencies:
should we also default to
1d
forsetMaximumValue
in newarch?react-native-slider/package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java
Lines 133 to 136 in f458a1c
ReactSliderManager.setValue
still accepts afloat
type forvalue
when the underlying implementation accepts adouble
?react-native-slider/package/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManagerImpl.java
Lines 38 to 45 in f458a1c
should we also change the param type for
value
todouble
?