Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve StepMarker #653

Closed
wants to merge 1 commit into from

Conversation

francois-pasquier
Copy link

Summary:

This will help with styling the StepMarker based on the index of the marker

Test Plan:

There is no functional change, this PR simply exposes a new prop to the StepMarker.

CleanShot 2024-10-07 at 22 48 37@2x

@BartoszKlonowski BartoszKlonowski self-requested a review February 14, 2025 11:52
@BartoszKlonowski
Copy link
Member

Hey @francois-pasquier!
Considering the work done in #655, can you let me know if the latest changes are sufficient? I think that #655 supersedes this PR, but I would like to take that opportunity of the case with your PR to hear from you whether there are any issues with what is on the latest of main branch currently, before we release the latest changes and close this PR as superseded.

@francois-pasquier
Copy link
Author

Hey @francois-pasquier! Considering the work done in #655, can you let me know if the latest changes are sufficient? I think that #655 supersedes this PR, but I would like to take that opportunity of the case with your PR to hear from you whether there are any issues with what is on the latest of main branch currently, before we release the latest changes and close this PR as superseded.

Looks like it does the trick, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants