-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slider has 0 height on Android with new architecture enabled #652
Comments
Hi @vonovak, thank you for reporting the issue. I have been able to solve the case with the codegen functionality and the fix is ready. However regarding the second issue - I have created new project with RN 75 and new arch enabled and the problem you have described does not exist, although I also was able to reproduce this while using the RNTA example. Since in basic usage this seems to be not relevant, I will not provide any fix for that, maybe this is some issue coming from RNTA itself. However from what I have seen the package can be patched by simply defining something like: |
Hey! Thanks for reporting the issue. I'm going to tag @tido64 here as this might be an issue inside of RNTA. We observed that the bare RN App calls the shadow node Any idea why this might happen? |
Hi! |
When resolving the version inside `react-native-config` which is used by the autolinking gradle tasks, the wrong use of require was used. This fix changes from using `require.main.require` -> `require`. The difference is that require.main.require resolves from the entry point (main script), while require resolves from the location of the current file. Closes callstack#652
# Why to resolve callstack/react-native-slider#652 callstack/react-native-slider#660 # How updated the package # Test Plan slider works in bare expo. iOS is smooth, Android is somewhat "jumpy" which I'll report to the package maintainers # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Description
[android only] While testing the project (I tested from the main branch) with new architecture (RN 0.75) I experienced 2 issues:
float
s instead ofdouble
s - that's hopefully easy to fixThis seems like a regression since #589 which was solving the same problem.
I'd be happy to submit a PR instead of an issue but I believe you'll be much better at figuring it out :).
Reproducible Demo
Please see the example at https://github.com/vonovak/react-native-slider/tree/fix/new-arch-issues/new-example
It's a fork of this repo, with new example added which uses https://github.com/microsoft/react-native-test-app (RNTA)
The example app was generated with
npx --package react-native-test-app@latest init
and then I modifiedmetro.config.js
andreact-native.config.js
to make it all work. Then I copied src directory from the existing example.Feel free to integrate that into the repo, RNTA is an amazing tool :).
The text was updated successfully, but these errors were encountered: