fix: new arch android interface (#654)

* fix: new arch android interface * fix: height on android * revert: fix android * Update package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java Co-authored-by: Vojtech Novak <vonovak@gmail.com> * Update package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java Co-authored-by: Vojtech Novak <vonovak@gmail.com> * Update package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java Co-authored-by: Vojtech Novak <vonovak@gmail.com> --------- Co-authored-by: Vojtech Novak <vonovak@gmail.com>
callstack · Oct 14, 2024 · ece95c3 · ece95c3
1 parent b528795
commit ece95c3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/example/package.json b/example/package.json
@@ -19,7 +19,7 @@
     "babel-preset-expo": "^9.2.0",
     "react": "18.2.0",
     "react-native": "0.73.5",
-    "react-native-pager-view": "^6.2.3",
+    "react-native-pager-view": "^6.4.1",
     "react-native-windows": "0.73.11"
   },
   "devDependencies": {

diff --git a/package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java b/package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java
@@ -125,12 +125,12 @@ public void setValue(ReactSlider view, float value) {
     ReactSliderManagerImpl.setValue(view, value);
   }
 
-  @ReactProp(name = "minimumValue", defaultFloat = 0f)
+  @ReactProp(name = "minimumValue", defaultDouble = 0d)
   public void setMinimumValue(ReactSlider view, double value) {
     ReactSliderManagerImpl.setMinimumValue(view, value);
   }
 
-  @ReactProp(name = "maximumValue", defaultFloat = 1f)
+  @ReactProp(name = "maximumValue", defaultDouble = 1d)
   public void setMaximumValue(ReactSlider view, double value) {
     ReactSliderManagerImpl.setMaximumValue(view, value);
   }
@@ -145,8 +145,8 @@ public void setUpperLimit(ReactSlider view, float value) {
     ReactSliderManagerImpl.setUpperLimit(view, value);
   }
 
-  @ReactProp(name = "step", defaultFloat = 0f)
-  public void setStep(ReactSlider view, float value) {
+  @ReactProp(name = "step", defaultDouble = 0d)
+  public void setStep(ReactSlider view, double value) {
     ReactSliderManagerImpl.setStep(view, value);
   }
 

diff --git a/package/src/RNCSliderNativeComponent.ts b/package/src/RNCSliderNativeComponent.ts
@@ -7,6 +7,7 @@ import type {
   WithDefault,
   DirectEventHandler,
   BubblingEventHandler,
+  Double,
 } from 'react-native/Libraries/Types/CodegenTypes';
 
 type Event = Readonly<{
@@ -23,15 +24,15 @@ export interface NativeProps extends ViewProps {
   tapToSeek?: WithDefault<boolean, false>;
   maximumTrackImage?: ImageSource;
   maximumTrackTintColor?: ColorValue;
-  maximumValue?: Float;
+  maximumValue?: Double;
   minimumTrackImage?: ImageSource;
   minimumTrackTintColor?: ColorValue;
-  minimumValue?: Float;
+  minimumValue?: Double;
   onChange?: BubblingEventHandler<Event>;
   onRNCSliderSlidingStart?: DirectEventHandler<Event>;
   onRNCSliderSlidingComplete?: DirectEventHandler<Event>;
   onRNCSliderValueChange?: BubblingEventHandler<Event>;
-  step?: Float;
+  step?: Double;
   testID?: string;
   thumbImage?: ImageSource;
   thumbTintColor?: ColorValue;