fix: floating number problem on android (#649)

* fix: floating number problem on android * fix: change number type from float to double * fix: remove unused imports
callstack · Sep 27, 2024 · 7986cc0 · 7986cc0
1 parent f3fb557
commit 7986cc0
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/package/android/src/main/java/com/reactnativecommunity/slider/ReactSlider.java b/package/android/src/main/java/com/reactnativecommunity/slider/ReactSlider.java
@@ -16,6 +16,7 @@
 import android.view.accessibility.AccessibilityEvent;
 import android.view.accessibility.AccessibilityManager;
 import androidx.appcompat.widget.AppCompatSeekBar;
+
 import java.net.URL;
 import java.util.List;
 import java.util.Timer;

diff --git a/package/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManagerImpl.java b/package/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManagerImpl.java
@@ -44,11 +44,11 @@ public static void setValue(ReactSlider view, double value) {
         }
     }
 
-    public static void setMinimumValue(ReactSlider view, float value) {
+    public static void setMinimumValue(ReactSlider view, double value) {
         view.setMinValue(value);
     }
 
-    public static void setMaximumValue(ReactSlider view, float value) {
+    public static void setMaximumValue(ReactSlider view, double value) {
         view.setMaxValue(value);
     }
 
@@ -60,7 +60,7 @@ public static void setUpperLimit(ReactSlider view, double value) {
         view.setUpperLimit(value);
     }
 
-    public static void setStep(ReactSlider view, float value) {
+    public static void setStep(ReactSlider view, double value) {
         view.setStep(value);
     }
 

diff --git a/package/android/src/newarch/java/com/reactnativecommunity/slider/ReactSliderManager.java b/package/android/src/newarch/java/com/reactnativecommunity/slider/ReactSliderManager.java
@@ -108,19 +108,19 @@ public void setValue(ReactSlider view, float value) {
 
   @Override
   @ReactProp(name = "minimumValue", defaultFloat = 0f)
-  public void setMinimumValue(ReactSlider view, float value) {
+  public void setMinimumValue(ReactSlider view, double value) {
     ReactSliderManagerImpl.setMinimumValue(view, value);
   }
 
   @Override
   @ReactProp(name = "maximumValue", defaultFloat = 0f)
-  public void setMaximumValue(ReactSlider view, float value) {
+  public void setMaximumValue(ReactSlider view, double value) {
     ReactSliderManagerImpl.setMaximumValue(view, value);
   }
 
   @Override
   @ReactProp(name = "step", defaultFloat = 0f)
-  public void setStep(ReactSlider view, float value) {
+  public void setStep(ReactSlider view, double value) {
     ReactSliderManagerImpl.setStep(view, value);
   }
 

diff --git a/package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java b/package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java
@@ -126,17 +126,17 @@ public void setValue(ReactSlider view, float value) {
   }
 
   @ReactProp(name = "minimumValue", defaultFloat = 0f)
-  public void setMinimumValue(ReactSlider view, float value) {
+  public void setMinimumValue(ReactSlider view, double value) {
     ReactSliderManagerImpl.setMinimumValue(view, value);
   }
 
   @ReactProp(name = "maximumValue", defaultFloat = 1f)
-  public void setMaximumValue(ReactSlider view, float value) {
+  public void setMaximumValue(ReactSlider view, double value) {
     ReactSliderManagerImpl.setMaximumValue(view, value);
   }
 
   @ReactProp(name = "lowerLimit")
-  public void setLowerLimit(ReactSlider view, float value) {
+  public void setLowerLimit(ReactSlider view, double value) {
     ReactSliderManagerImpl.setLowerLimit(view, value);
   }