Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Xcode 11 error #86

Closed
wants to merge 1 commit into from
Closed

fix: Xcode 11 error #86

wants to merge 1 commit into from

Conversation

troZee
Copy link
Member

@troZee troZee commented Oct 28, 2019 •
edited
Loading

Summary

fix: add patch to react package

Close #85

Test Plan

Just run the app

Compatibility

OS Implemented
iOS ✅
Android ❌

Checklist

  • I have tested this on a device and a simulator

@troZee troZee requested review from dratwas and ferrannp October 28, 2019 10:10
@ferrannp
Copy link
Contributor

@troZee I am pretty sure we do not want this in here. If somebody is using react-native 0.58.4 and they need to patch it, it is something they need to do in their app. The fact that you patch it here won't affect the app that is consuming this library.

@troZee troZee closed this Oct 28, 2019
@troZee troZee deleted the troZee/fix-xcode-11 branch June 22, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dratwas dratwas Awaiting requested review from dratwas

@ferrannp ferrannp Awaiting requested review from ferrannp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XCode 11 App Launch Crash
2 participants
@troZee @ferrannp