chore: migrate more files to TS #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll check tonight or in Tuesday |
c0e1d4f to
4688df0
Compare
4688df0 to
e02a65e
Compare
Anber
reviewed
May 6, 2019
This was referenced May 16, 2019
Closed
|
FYI: #387 |
Closed
|
@satya164 @pbitkowski @thymikee
I probably won't have time to deal with that in the next days, so if someone wants to do it, feel free. |
thymikee
requested changes
May 19, 2019
zamotany
commented
May 20, 2019
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>
thymikee
approved these changes
May 20, 2019
|
Let's merge it all and release first alpha! :) |
satya164
approved these changes
May 27, 2019
Anber
pushed a commit
that referenced
this pull request
Dec 26, 2019
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com> Co-Authored-By: Satyajit Sahoo <satyajit.happy@gmail.com>
Anber
pushed a commit
that referenced
this pull request
Jan 12, 2020
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com> Co-Authored-By: Satyajit Sahoo <satyajit.happy@gmail.com>
Anber
pushed a commit
that referenced
this pull request
Jan 14, 2020
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com> Co-Authored-By: Satyajit Sahoo <satyajit.happy@gmail.com>
Anber
pushed a commit
that referenced
this pull request
Feb 4, 2020
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com> Co-Authored-By: Satyajit Sahoo <satyajit.happy@gmail.com>
Anber
pushed a commit
that referenced
this pull request
Feb 9, 2020
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com> Co-Authored-By: Satyajit Sahoo <satyajit.happy@gmail.com>
Anber
pushed a commit
that referenced
this pull request
Feb 10, 2020
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com> Co-Authored-By: Satyajit Sahoo <satyajit.happy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/index.jswas not migrated as it's breaking the tests, probably something with resolving linaria import is working as expectedsrc/react/*.js- same story, even changing the extension causes tests to fail@satya164 do you have any idea why that is happening? Or how we can solve that?