Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scope option for libraries #299

Closed
zamotany opened this issue Jan 16, 2019 · 4 comments
Closed

Add scope option for libraries #299

zamotany opened this issue Jan 16, 2019 · 4 comments
Labels
cat: improve publishing 🚢 Issues about improvement of publishing libs with Linaria feature: approved ✅ New feature that has been approved good first issue 😊 It is a good issue for new comers status: has PR 😍 Issue has opened PR
Milestone
2.0.0 release

Comments

@zamotany
Copy link
Contributor

Do you want to request a feature or report a bug?
feature

What is the current behavior?

If the current behavior is a bug, please provide the steps to reproduce and a minimal repository on GitHub that we can yarn install and yarn test.

What is the expected behavior?

Please provide your exact Babel configuration and mention your Linaria, Node, Yarn/npm version and operating system.
@zamotany zamotany mentioned this issue Jan 16, 2019
Closed
chrisbateman added a commit to chrisbateman/linaria that referenced this issue Mar 31, 2019
@chrisbateman
feat: scope option for libraries
5da19e1 
see callstack#299, callstack#208, callstack#178
chrisbateman added a commit to chrisbateman/linaria that referenced this issue Mar 31, 2019
@chrisbateman
feat: scope option for libraries
ed48bad 
Closes callstack#299. See also callstack#208, callstack#178
@chrisbateman chrisbateman mentioned this issue Mar 31, 2019
Closed
chrisbateman added a commit to chrisbateman/linaria that referenced this issue Mar 31, 2019
@chrisbateman
feat: scope option for libraries
53206bb 
Closes callstack#299. See also callstack#208, callstack#178
chrisbateman added a commit to chrisbateman/linaria that referenced this issue Mar 31, 2019
@chrisbateman
feat: scope option for libraries
bac422f 
Closes callstack#299. See also callstack#208, callstack#178
chrisbateman added a commit to chrisbateman/linaria that referenced this issue Apr 3, 2019
@chrisbateman
feat: unique classnames based on package name/version,
eb6b626 
new classPrefix option

Closes callstack#299. See also callstack#208, callstack#178
chrisbateman added a commit to chrisbateman/linaria that referenced this issue Apr 3, 2019
@chrisbateman
feat: unique classnames based on package name/version,
d2f3a9e 
new classPrefix option

Closes callstack#299. See also callstack#208, callstack#178
@pbitkowski pbitkowski added the feature: proposal 💬 New feature proposal that needs to be discussed label May 16, 2019
@jayu
Copy link
Contributor

jayu commented Apr 1, 2020 •
edited
Loading

@zamotany what is a use case for this feature. Do you want to be able to add a prefix to class names generated by linaria? It would be useful while building component libraries, right?

@jayu jayu added the cat: improve publishing 🚢 Issues about improvement of publishing libs with Linaria label Apr 1, 2020
@thymikee
Copy link
Member

thymikee commented Apr 1, 2020

Yup, avoiding classname conflicts when publishing css from a library was the goal

@jayu jayu added feature: approved ✅ New feature that has been approved status: has PR 😍 Issue has opened PR and removed feature: proposal 💬 New feature proposal that needs to be discussed labels Apr 1, 2020
@jayu jayu added this to the 2.0.0 release milestone Apr 4, 2020
@jayu
Copy link
Contributor

jayu commented Apr 14, 2020

Since code for this feature is already there (#369), but only needs migration to TypeScript, I mark it as good first issue

@jayu jayu added the good first issue 😊 It is a good issue for new comers label Apr 14, 2020
@jayu
Copy link
Contributor

jayu commented Apr 23, 2020

I missed out that we have classNameSlug option. So it is possible to have library scoped class name now.

@jayu jayu closed this as completed Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cat: improve publishing 🚢 Issues about improvement of publishing libs with Linaria feature: approved ✅ New feature that has been approved good first issue 😊 It is a good issue for new comers status: has PR 😍 Issue has opened PR
Projects
None yet
Milestone
2.0.0 release
Development

No branches or pull requests
4 participants
@thymikee @jayu @zamotany @pbitkowski