refactor: use classReflection::is method

calebdw · Sep 14, 2024 · f0b347b · f0b347b
1 parent 6882371
commit f0b347b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/src/Methods/EloquentBuilderForwardsCallsExtension.php b/src/Methods/EloquentBuilderForwardsCallsExtension.php
@@ -66,7 +66,7 @@ public function getMethod(ClassReflection $classReflection, string $methodName):
      */
     private function findMethod(ClassReflection $classReflection, string $methodName): MethodReflection|null
     {
-        if ($classReflection->getName() !== EloquentBuilder::class && ! $classReflection->isSubclassOf(EloquentBuilder::class)) {
+        if (! $classReflection->is(EloquentBuilder::class)) {
             return null;
         }
 

diff --git a/src/Methods/MacroMethodsClassReflectionExtension.php b/src/Methods/MacroMethodsClassReflectionExtension.php
@@ -70,9 +70,8 @@ public function hasMethod(ClassReflection $classReflection, string $methodName):
             }
         } elseif (
             $this->hasIndirectTraitUse($classReflection, Macroable::class) ||
-            $classReflection->getName() === Builder::class ||
-            $classReflection->isSubclassOf(Builder::class) ||
-            $classReflection->getName() === QueryBuilder::class
+            $classReflection->is(Builder::class) ||
+            $classReflection->is(QueryBuilder::class)
         ) {
             $classNames         = [$classReflection->getName()];
             $macroTraitProperty = 'macros';

diff --git a/src/Methods/ModelForwardsCallsExtension.php b/src/Methods/ModelForwardsCallsExtension.php
@@ -72,7 +72,7 @@ public function getMethod(ClassReflection $classReflection, string $methodName):
      */
     private function findMethod(ClassReflection $classReflection, string $methodName): MethodReflection|null
     {
-        if ($classReflection->getName() !== Model::class && ! $classReflection->isSubclassOf(Model::class)) {
+        if (! $classReflection->is(Model::class)) {
             return null;
         }
 

diff --git a/src/Support/CollectionHelper.php b/src/Support/CollectionHelper.php
@@ -109,7 +109,7 @@ private function getTypeFromEloquentCollection(ClassReflection $classReflection)
 
         $innerValueType = $classReflection->getActiveTemplateTypeMap()->getType('TModel');
 
-        if ($classReflection->getName() === EloquentCollection::class || $classReflection->isSubclassOf(EloquentCollection::class)) {
+        if ($classReflection->is(EloquentCollection::class)) {
             $keyType = new IntegerType();
         }