chore: Add Prisma extension to block deleteMany/updateMany with undefined 'in' #15721
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
|
Ig this should be applied to deleteMany as well. DeleteMany without where would also delete all rows @keithwillcode |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Eighty-four Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Yes absolutely. I was looking through the code base and we have a few deleteMany. Was planning to add here. Great call out 🙏🏼 |
| const whereInput = where[key as any] as any; | ||
| let message; | ||
| if (!whereInput) { |
There was a problem hiding this comment.
This always fails if a whereInput value is false, and you get an error without passing undefined.
There was a problem hiding this comment.
Nice find, @anikdhabal. And from Prisma's docs, with null, they won't ignore the params, only with undefined so this change is ok.
What does this PR do?
Adds a Prisma extension that will throw errors any time we try and call
updateManyand the value for theinfield is undefined.Prisma's default behavior in this case is just to update all records.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
updateManyand ensure the functionality is fine