Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: browser push notifications #14888
feat: browser push notifications #14888
Changes from all commits
7e6ee5c
d051e3d
f995147
6306030
ccb096c
e6745ac
0d2f182
cdb019a
376171f
3515600
7c28a52
516ceb3
77c2dac
9065229
49b6f0a
b2a047a
fd66721
1e07b2a
9b102c1
6ff00f0
77dcfe9
18a5476
8d24843
7e3b1c4
096069e
f7ac3c3
109f842
6f3b87b
6519e0a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can enable push notifications on brave by enabling this and relaunching browser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, so I was wondering if there is some browser API that we can call on the user's confirmation to enable this for them on the brave browser. What do you say?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw there is no such option, but should we guide user by showing screenshot? and probably redirect them to this setting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brave://settings/?search=push+messaging
You can add this link and it would redirect to settings page with option highlighted. No need for screenshot.