(#730) added a new script task ensureCi
#731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensureCiensureCi
3938b5b to
6378e51
Compare
Which calls "npm ci", if node_modules does not exist. By calling this before the "watch" task, the workflow of clone, start VSCode, hit F5 will "simply work".
6378e51 to
2a7197a
Compare
|
@nils-a thanks for getting this fixed up. I have taken this for a spin locally, and happy to say that it works exactly as expected now. |
nils-a
added a commit
to nils-a/cake-vscode
that referenced
this pull request
Oct 13, 2022
This is a regression from cake-build#731 where everything will work fine, if node_modules does not exist. However, if it does exist the non-zero exit code will propagate and prevent tsc from running. By adding a second, "parallel" command to ensureCi the exit code of that script will always be zero and thus never prevent tsc from running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which calls "npm ci", if
node_modulesdoes not exist. By calling this before the "watch" task,the workflow of clone, start VSCode, hit F5 will "simply work".
fixes #730