Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[embeddings] extend kwargs to functions that call _encode_with_retry #400

Merged
merged 1 commit into from
Nov 7, 2024
Merged

[embeddings] extend kwargs to functions that call _encode_with_retry #400

merged 1 commit into from
Nov 7, 2024

Conversation

kcirred
Copy link
Contributor

@kcirred kcirred commented Oct 28, 2024

No description provided.

@kcirred
[embeddings] extend kwargs to high level functions
874982b 
Signed-off-by: kcirred <16872435+kcirred@users.noreply.github.com>
gkumbhat
gkumbhat reviewed Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@gkumbhat gkumbhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kcirred , can you please provide a bit of context behind why this PR is required, what it does, how can user use this change and how was it tested ?

gkumbhat
gkumbhat approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@gkumbhat gkumbhat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

The details of the PR were discussed separately!

@gkumbhat gkumbhat merged commit 56b7e18 into caikit:main Nov 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkumbhat gkumbhat gkumbhat approved these changes

@alex-jw-brooks alex-jw-brooks Awaiting requested review from alex-jw-brooks alex-jw-brooks is a code owner

@evaline-ju evaline-ju Awaiting requested review from evaline-ju evaline-ju is a code owner

@gabe-l-hart gabe-l-hart Awaiting requested review from gabe-l-hart gabe-l-hart is a code owner

@tharapalanivel tharapalanivel Awaiting requested review from tharapalanivel tharapalanivel is a code owner

@Ssukriti Ssukriti Awaiting requested review from Ssukriti Ssukriti is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kcirred @gkumbhat