generated from caikit/caikit-template
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📦 Update torch to 2.3.1 #368
Merged
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9719b42
:package: Update torch to 2.3.1
gkumbhat 4d0dfc4
:bug: Remove tee from torch launch config to correspond to API change…
gkumbhat cc86f6b
:art: Fix lint by removing unused import
gkumbhat 314db01
Changes result vector comparison to approximately.
flaviabeo b53f7ab
Merge pull request #8 from flaviabeo/update_torch_2_3_1_fix_test
gkumbhat d621b53
:art: Fix formatting
gkumbhat 59ae6d5
:bug: Replace allclose to isclose
gkumbhat 3cecf52
Adds tolerance params
flaviabeo 0cf2c94
Merge pull request #9 from flaviabeo/tolerance
gkumbhat f4883e3
:bug: Fix isclose to .all
gkumbhat 9e3dda6
:recycle: Replace isclose().all logic to allclose as before
gkumbhat b4e5108
:art: Fix formatting
gkumbhat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q - what's the difference between
isclose.all()
here vs.allclose
? Can'tallclose
also take the rtol etc. https://numpy.org/doc/stable/reference/generated/numpy.allclose.html