-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: use setuptools/setuptools_scm for building #216
Conversation
An example of what the version generated by |
373e9ec
to
e0f6a63
Compare
Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com>
e0f6a63
to
1d36715
Compare
Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com>
1d36715
to
56f09ea
Compare
Hey @gabe-l-hart, do you have any bandwidth to have a look at this and/or discuss it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change. @gabe-l-hart or @evaline-ju or @joerunde thoughts on this? Also do we want to include this for caikit
as well?
Currently caikit-nlp
cannot be published to pypi itself because of peft version, but something seems this would be useful for caikit and once we are able to push caikit-nlp to pypi.
I have a patch ready for caikit aswell if this is approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dtrifiro yeah this looks better than what we whipped up when we pulled this all out into github. Thanks!
Can you go ahead and make the change to caikit as well?
Ah, I am not a code owner here so I'd actually need @gkumbhat to hit approve on this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you!
This PR had a small issue which was fixed in #239, see pypa/setuptools#3340 for more context. |
This PR changes the build system from
flit
tosetuptools
+setuptools_scm
. The main driver behind this PR is to simplify development by havingsetuptools_scm
automatically set the module version at build/install time instead of having a fixed0.0.1
version replaced by CI.Another advantage of using
setuptools_scm
is to have proper versions reported when using editable installs, avoiding version requirements warnings/errors.This also adds the possibility of using
caikit_nlp.__version__
(or__version_tuple__
) to check the module version at runtime