Skip to content

Commit

Permalink
lit tests updated
Browse files Browse the repository at this point in the history
  • Loading branch information
@caiiiycuk
caiiiycuk committed Nov 1, 2023
1 parent bc7e5d1 commit 22a248b
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions test/lit/passes/asyncify_pass-arg=asyncify-asserts_pass-arg=asyncify-onlylist@waka.wast
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
(memory 1 2)
;; CHECK: (type $f (func))
(type $f (func))
;; CHECK: (type $none_=>_i32 (func (result i32)))
;; CHECK: (type $1 (func (result i32)))

;; CHECK: (type $i32_=>_none (func (param i32)))
;; CHECK: (type $2 (func (param i32)))

;; CHECK: (import "env" "import" (func $import))
(import "env" "import" (func $import))
Expand Down
6 changes: 3 additions & 3 deletions test/lit/passes/asyncify_pass-arg=asyncify-eh-asserts.wast
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@

(module
(memory 1 2)
;; CHECK: (type $none_=>_none (func))
;; CHECK: (type $0 (func))

;; CHECK: (type $i32_=>_none (func (param i32)))
;; CHECK: (type $1 (func (param i32)))

;; CHECK: (type $none_=>_i32 (func (result i32)))
;; CHECK: (type $2 (func (result i32)))

;; CHECK: (import "extmod" "exttag" (tag $default (param i32)))
(import "extmod" "exttag" (tag $default (param i32)))
Expand Down
6 changes: 3 additions & 3 deletions test/lit/passes/asyncify_pass-arg=asyncify-eh-ignore.wast
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@

(module
(memory 1 2)
;; CHECK: (type $none_=>_none (func))
;; CHECK: (type $0 (func))

;; CHECK: (type $i32_=>_none (func (param i32)))
;; CHECK: (type $1 (func (param i32)))

;; CHECK: (type $none_=>_i32 (func (result i32)))
;; CHECK: (type $2 (func (result i32)))

;; CHECK: (import "extmod" "exttag" (tag $default (param i32)))
(import "extmod" "exttag" (tag $default (param i32)))
Expand Down
6 changes: 3 additions & 3 deletions test/lit/passes/asyncify_pass-arg=asyncify-eh.wast
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@

(module
(memory 1 2)
;; CHECK: (type $none_=>_none (func))
;; CHECK: (type $0 (func))

;; CHECK: (type $i32_=>_none (func (param i32)))
;; CHECK: (type $1 (func (param i32)))

;; CHECK: (type $none_=>_i32 (func (result i32)))
;; CHECK: (type $2 (func (result i32)))

;; CHECK: (import "extmod" "exttag" (tag $default (param i32)))
(import "extmod" "exttag" (tag $default (param i32)))
Expand Down

8 comments on commit 22a248b

@allsey87
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caiiiycuk could you let me know which version of Emscripten you are using with this fork of Binaryen?

@caiiiycuk
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest

@allsey87
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick reply, are you overriding any of the following CMake flags when you build Binaryen: EMSCRIPTEN_ENABLE_WASM_EH, BYN_ENABLE_ASSERTIONS, BYN_ENABLE_LTO?

@caiiiycuk
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you experiencing any issues with the build? I haven't tested it extensively.

@allsey87
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am having some issues building after the latest commits to your fork:

incomplete type ‘std::variant_size’ used in nested name specifier

and:

cc1plus: error: unrecognized command line option ‘-Wno-unknown-warning-option’ [-Werror]
cc1plus: error: unrecognized command line option ‘-Wno-implicit-int-float-conversion’ [-Werror]
cc1plus: error: unrecognized command line option ‘-Wno-dangling-pointer’ [-Werror]

Still investigating, so far I have only tried bumping the standard to C++20 via -DCMAKE_CXX_STANDARD=20 although I think C++17 should also be supported. I am also passing -DBUILD_TESTS=OFF and -DBUILD_STATIC_LIB=ON to cmake at the moment. The latter was a workaround for some dynamic linking issues I was having earlier (cannot remember the details).

@caiiiycuk
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe you used wrong version of compiler. At least for me everything is compiled.

@allsey87
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely possible. I am using gcc version 8.3.0 (Debian 8.3.0-6) from the build-essential package on Debian Buster

@allsey87
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to gcc version 12.2.0 (Debian 12.2.0-14) resolved these compile errors.

Please sign in to comment.