Fix wrong settings for topics

cafebazaar · Aug 31, 2020 · 9ec135f · 9ec135f
1 parent 888ebc3
commit 9ec135f
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 5 deletions.
diff --git a/snuba/datasets/storages/errors.py b/snuba/datasets/storages/errors.py
@@ -217,7 +217,7 @@ def errors_migrations(
     stream_loader=KafkaStreamLoader(
         processor=ErrorsProcessor(promoted_tag_columns),
         default_topic=settings.EVENTS_TOPIC,
-        replacement_topic=settings.REPLACEMENTS_TOPIC,
+        replacement_topic=settings.ERRORS_REPLACEMENTS_TOPIC,
     ),
     replacer_processor=ErrorsReplacer(
         write_schema=schema,

diff --git a/snuba/datasets/storages/events.py b/snuba/datasets/storages/events.py
@@ -121,7 +121,7 @@ def events_migrations(
     stream_loader=KafkaStreamLoader(
         processor=EventsProcessor(promoted_tag_columns),
         default_topic=settings.EVENTS_TOPIC,
-        replacement_topic=settings.REPLACEMENTS_TOPIC,
+        replacement_topic=settings.EVENT_REPLACEMENTS_TOPIC,
         commit_log_topic=settings.COMMIT_LOG_TOPIC,
     ),
     query_splitters=query_splitters,

diff --git a/snuba/perf.py b/snuba/perf.py
@@ -28,7 +28,7 @@ def get_messages(events_file) -> Sequence[Message[KafkaPayload]]:
     for raw_event in raw_events:
         messages.append(
             Message(
-                Partition(Topic(settings.DEFAULT_TOPIC), 1),
+                Partition(Topic(settings.EVENTS_TOPIC), 1),
                 0,
                 KafkaPayload(None, raw_event.encode("utf-8")),
                 datetime.now(),

diff --git a/snuba/settings.py b/snuba/settings.py
@@ -102,7 +102,8 @@
 PROJECT_STACKTRACE_BLACKLIST: Set[int] = set()
 
 EVENTS_TOPIC = "events"
-REPLACEMENTS_TOPIC = "event-replacements"
+EVENT_REPLACEMENTS_TOPIC = "event-replacements"
+ERRORS_REPLACEMENTS_TOPIC = "errors-replacements"
 COMMIT_LOG_TOPIC = "snuba-commit-logs"
 CDC_TOPIC = "cdc"
 OUTCOMES_TOPIC = "outcomes"

diff --git a/snuba/settings_docker.py b/snuba/settings_docker.py
@@ -13,7 +13,8 @@
 USE_REDIS_CLUSTER = False
 
 EVENTS_TOPIC = env("EVENTS_TOPIC", "events")
-REPLACEMENTS_TOPIC = env("REPLACEMENT_TOPIC", "event-replacements")
+EVENT_REPLACEMENTS_TOPIC = env("EVENT_REPLACEMENT_TOPIC", "event-replacements")
+ERRORS_REPLACEMENTS_TOPIC = env("ERRORS_REPLACEMENT_TOPIC", "errors-replacements")
 COMMIT_LOG_TOPIC = env("COMMIT_LOG_TOPIC", "snuba-commit-logs")
 CDC_TOPIC = env("CDC_TOPIC", "cdc")
 OUTCOMES_TOPIC = env("OUTCOMES_TOPIC", "outcomes")