Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidated data #12

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Invalidated data #12

merged 1 commit into from
Sep 22, 2020

Conversation

Mesod
Copy link
Contributor

@Mesod Mesod commented Sep 22, 2020

To set data in Redis, command SET was being used with NX option which only applies the data when no previous data is stored in the database under the same Key. As mnemosyne caching mechanisms is hardly relied on SoftTTL mechanism, using SET NX avoids the library to update the cache as it's planned and data with passed SoftTTL duration will still remain in the database until it reaches to its actual TTL and no processes can update it before.

@pedramteymoori
Copy link
Contributor

pedramteymoori commented Sep 22, 2020

Thanks @Mesod !
This fix will address our low hit-rate on Redis-layer during deploys.
I'll merge it into V2 (V1 actually) and merge it to master after that.

@pedramteymoori pedramteymoori merged commit 73cd8b0 into cafebazaar:v2 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants