Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX CRASH: call getIndexForTarget only when targetSequence is not nil #30

Merged
merged 1 commit into from
Jan 11, 2025
Merged

FIX CRASH: call getIndexForTarget only when targetSequence is not nil #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Panels.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,9 +682,10 @@ end
local function nextSequence()
local isDeadEnd = sequence.endSequence or false
unloadSequence()


local targetIndex = targetSequence and getIndexForTarget(targetSequence) or nil

if targetSequence then
local targetIndex = getIndexForTarget(targetSequence)
loadSequence(targetIndex)
targetSequence = nil
updateMenuData(sequences, gameDidFinish, currentSeqIndex > 1)
Expand All @@ -695,7 +696,6 @@ local function nextSequence()
elseif isCutscene then
playdate.inputHandlers.pop()
gameDidFinish = true
local targetIndex = getIndexForTarget(targetSequence)
cutsceneFinishCallback(targetIndex)
Panels.Audio.killBGAudio()
previousBGColor = nil -- prevent future cross-fade attempt
Expand Down