Skip to content

Commit

Permalink
feat(v8/angular): Merge angular and angular-ivy packages and start An…
Browse files Browse the repository at this point in the history
…gular support at v14 (getsentry#11091)

Start using vitest for better ESM support (since Angular 13)
closes getsentry#9830

---------

Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
  • Loading branch information
2 people authored and cadesalaberry committed Apr 19, 2024
1 parent 7794d65 commit 71823bc
Show file tree
Hide file tree
Showing 52 changed files with 2,803 additions and 5,861 deletions.
5 changes: 0 additions & 5 deletions .craft.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ targets:
includeNames: /^sentry-profiling-node-\d.*\.tgz$/

## 3 Browser-based Packages
- name: npm
id: '@sentry/angular-ivy'
includeNames: /^sentry-angular-ivy-\d.*\.tgz$/
- name: npm
id: '@sentry/angular'
includeNames: /^sentry-angular-\d.*\.tgz$/
Expand Down Expand Up @@ -179,8 +176,6 @@ targets:
onlyIfPresent: /^sentry-vue-\d.*\.tgz$/
'npm:@sentry/gatsby':
onlyIfPresent: /^sentry-gatsby-\d.*\.tgz$/
'npm:@sentry/angular-ivy':
onlyIfPresent: /^sentry-angular-ivy-\d.*\.tgz$/
'npm:@sentry/angular':
onlyIfPresent: /^sentry-angular-\d.*\.tgz$/
'npm:@sentry/astro':
Expand Down
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/bug.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ body:
- '@sentry/browser'
- '@sentry/astro'
- '@sentry/angular'
- '@sentry/angular-ivy'
- '@sentry/aws-serverless'
- '@sentry/bun'
- '@sentry/deno'
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/issue-package-label.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ jobs:
"@sentry.angular": {
"label": "Package: Angular"
},
"@sentry.angular-ivy": {
"label": "Package: Angular"
},
"@sentry.bun": {
"label": "Package: Bun"
},
Expand Down
7 changes: 7 additions & 0 deletions MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,13 @@ Sentry SDK requires the fetch API to be available in the environment.

The `wrap` method has been removed. There is no replacement API.

#### Removal of `@sentry/angular-ivy` package

The `@sentry/angular-ivy` package has been removed. The `@sentry/angular` package now supports Ivy by default and
requires at least Angular 14. If you are using Angular 13 or lower, we suggest upgrading your Angular version before
migrating to v8. If you can't upgrade your Angular version to at least Angular 14, you can also continue using the
`@sentry/angular-ivy@7` SDK. However, v7 of the SDKs will no longer be fully supported going forward.

### Server-side SDKs (Node, Deno, Bun, etc.)

Removed top-level exports: `enableAnrDetection`, `Anr`, `deepReadDirSync`
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ package. Please refer to the README and instructions of those SDKs for more deta
integrations for Express
- [`@sentry/angular`](https://github.com/getsentry/sentry-javascript/tree/master/packages/angular): Browser SDK for
Angular
- [`@sentry/angular-ivy`](https://github.com/getsentry/sentry-javascript/tree/master/packages/angular-ivy): Browser SDK
for Angular with native support for Angular's Ivy rendering engine.
- [`@sentry/astro`](https://github.com/getsentry/sentry-javascript/tree/master/packages/astro): SDK for Astro
- [`@sentry/ember`](https://github.com/getsentry/sentry-javascript/tree/master/packages/ember): Browser SDK for Ember
- [`@sentry/react`](https://github.com/getsentry/sentry-javascript/tree/master/packages/react): Browser SDK for React
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Angular17

E2E test app for Angular 17 and `@sentry/angular-ivy`.
E2E test app for Angular 17 and `@sentry/angular`.
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"@angular/platform-browser": "^17.1.0",
"@angular/platform-browser-dynamic": "^17.1.0",
"@angular/router": "^17.1.0",
"@sentry/angular-ivy": "* || latest",
"@sentry/angular": "* || latest",
"rxjs": "~7.8.0",
"tslib": "^2.3.0",
"zone.js": "~0.14.3"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { APP_INITIALIZER, ApplicationConfig, ErrorHandler } from '@angular/core';
import { Router, provideRouter } from '@angular/router';

import { TraceService, createErrorHandler } from '@sentry/angular-ivy';
import { TraceService, createErrorHandler } from '@sentry/angular';
import { routes } from './app.routes';

export const appConfig: ApplicationConfig = {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { AfterViewInit, Component, OnInit } from '@angular/core';
import { TraceClass, TraceMethod, TraceModule } from '@sentry/angular-ivy';
import { TraceClass, TraceMethod, TraceModule } from '@sentry/angular';
import { SampleComponent } from '../sample-component/sample-component.components';

@Component({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { RouterLink } from '@angular/router';
<li> <a id="redirectLink" [routerLink]="['/redirect1']">Redirect</a> </li>
<li> <a id="cancelLink" [routerLink]="['/cancel']">Cancel</a> </li>
<li> <a id="nonExistentLink" [routerLink]="['/non-existent']">Error</a> </li>
<li> <a id="componentTracking" [routerLink]="['/component-tracking']">Error</a> </li>
<li> <a id="componentTracking" [routerLink]="['/component-tracking']">Component Tracking</a> </li>
</ul>
<button id="errorBtn" (click)="throwError()">Throw error</button>
</main>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { bootstrapApplication } from '@angular/platform-browser';
import { AppComponent } from './app/app.component';
import { appConfig } from './app/app.config';

import * as Sentry from '@sentry/angular-ivy';
import * as Sentry from '@sentry/angular';

Sentry.init({
dsn: 'https://3b6c388182fb435097f41d181be2b2ba@o4504321058471936.ingest.sentry.io/4504321066008576',
Expand Down
6 changes: 0 additions & 6 deletions dev-packages/e2e-tests/verdaccio-config/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,6 @@ packages:
unpublish: $all
# proxy: npmjs # Don't proxy for E2E tests!

'@sentry/angular-ivy':
access: $all
publish: $all
unpublish: $all
# proxy: npmjs # Don't proxy for E2E tests!

'@sentry/astro':
access: $all
publish: $all
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
},
"workspaces": [
"packages/angular",
"packages/angular-ivy",
"packages/astro",
"packages/aws-serverless",
"packages/browser",
Expand Down
14 changes: 0 additions & 14 deletions packages/angular-ivy/LICENSE

This file was deleted.

234 changes: 0 additions & 234 deletions packages/angular-ivy/README.md

This file was deleted.

Loading

0 comments on commit 71823bc

Please sign in to comment.