Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selecting items in Workflow History Timeline #812

Open
wants to merge 3 commits into
base: release/4.0.0
Choose a base branch
from

Conversation

adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Feb 7, 2025

Summary

  • Add onClickItem handler to Timeline that gets called when the VisJS Timeline registers a click on an item
  • Add "id" number to TimelineItem
  • Set selected event in query params and scroll to it when an item is selected in the timeline
  • Refactor Workflow Timeline Styles to share common styles across different items and states
  • Added rounding to non-timer items
  • Removed rounding from timer items

Test Plan

Updated unit tests + ran locally.

Regular event group selected
image

Single event selected
Screenshot 2025-02-07 at 3 51 17 PM

Timer selected
Screenshot 2025-02-07 at 3 51 23 PM

@adhityamamallan adhityamamallan marked this pull request as ready for review February 7, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants