Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config for workflow actions #805

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Add config for workflow actions #805

merged 7 commits into from
Feb 4, 2025

Conversation

adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Feb 3, 2025 •
edited
Loading

Summary

  • Add type WorkflowActionID
  • Add dynamic config to enable/disable workflow actions
  • Use useConfigValue to load this config in the Workflow Actions button
  • Change getIsEnabled to getIsRunnable for Workflow Action, to differentiate it from actionsEnabledConfig

Test plan

Unit tests + ran locally.

Screen.Recording.2025-02-03.at.3.38.25.PM.mov
Screenshot 2025-02-03 at 12 48 43 PM

@adhityamamallan adhityamamallan marked this pull request as ready for review February 3, 2025 15:01
@Assem-Uber Assem-Uber merged commit 5f0a7f3 into cadence-workflow:release/4.0.0 Feb 4, 2025
1 check passed
@adhityamamallan adhityamamallan deleted the 2-actions-config branch February 4, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Assem-Uber Assem-Uber Assem-Uber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adhityamamallan @Assem-Uber