Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign ListenerService #231

Closed
takeshishimada opened this issue Jul 16, 2019 · 0 comments
Closed

Redesign ListenerService #231

takeshishimada opened this issue Jul 16, 2019 · 0 comments

Comments

@takeshishimada
Copy link
Member

takeshishimada commented Jul 16, 2019

Use AOP pattern instead of ListenerService

ListenerService should be deleted because most of uses dose not use all methods defined in it.
If need injection before or after processing, create inheritance class and inject it.

  1. Delete ListenerService
  2. Move components under infrastructureへ
  3. Rename 'components' to 'services'
  4. Rename 'services' to 'implements'
  5. Delete '@singleton' from all services in 'application.services' packate
  6. Create 'application.modules' package
  7. Create ServicesModule
takeshishimada pushed a commit that referenced this issue Jul 20, 2019
takeshishimada added a commit that referenced this issue Jul 21, 2019
Redesign ListenerService (#231)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant