Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add bin folder to .devenv #175

Closed
wants to merge 2 commits into from
Closed

feat: add bin folder to .devenv #175

wants to merge 2 commits into from

Conversation

shyim
Copy link
Contributor

@shyim shyim commented Dec 2, 2022 •
edited
Loading

  • Reduces the $PATH by only adding one packages with a bin folder
  • Symlinks the bin to .devenv/bin so I can pass this as interpreter path to PhpStorm

fixes #167

@thenonameguy
Copy link
Contributor

My reverted mkNakedShell PR fixes this as well. Let me do that instead over the weekend.

@shyim
Copy link
Contributor Author

shyim commented Dec 3, 2022

@thenonameguy will you create also a bin folder? Ot should I just revert the shell changes :)

@thenonameguy
Copy link
Contributor

thenonameguy commented Dec 5, 2022 •
edited
Loading

@shyim It will create the $DEVENV_PROFILE/bin folder as well as well as adding it to the PATH. See here
I have made the modifications, just writing tests for testing the native extension building (correct pkg-config/ld env vars).

@thenonameguy thenonameguy mentioned this pull request Dec 5, 2022
Merged
@shyim shyim closed this Dec 5, 2022
@shyim
Copy link
Contributor Author

shyim commented Dec 5, 2022

I will make my own module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar domenkozar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate a bin folder inside .devenv
3 participants
@shyim @thenonameguy @domenkozar