Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redix dependency version to ~> 0.11 #19

Closed
diogommartins opened this issue Aug 23, 2020 · 5 comments
Closed

Update redix dependency version to ~> 0.11 #19

diogommartins opened this issue Aug 23, 2020 · 5 comments

Comments

@diogommartins
Copy link
Contributor

diogommartins commented Aug 23, 2020

It has a lot of improvements and it's the current version supported by the newest new_relic_agent. Since it doesn't seem to be much work to be done is it ok if submit a pull request doing the change?

Redix changelog:
https://github.com/whatyouhide/redix/blob/main/CHANGELOG.md

@diogommartins diogommartins changed the title Update redix version to 0.11 Update redix dependency version to ~> 0.11 Aug 23, 2020
@cabol
Copy link
Owner

cabol commented Aug 24, 2020

@diogommartins absolutely, it would be great if you send a PR with the fix, looking forward to that, thanks 😉 !!

@diogommartins
Copy link
Contributor Author

Working on it !

diogommartins added a commit to diogommartins/nebulex_redis_adapter that referenced this issue Aug 29, 2020
cabol pushed a commit that referenced this issue Aug 30, 2020
@diogommartins
Copy link
Contributor Author

Hey @cabol do you think that there's something else to be done before releasing a new version?

@cabol
Copy link
Owner

cabol commented Sep 2, 2020

I don't think so, but I'll check if there is anything pending, otherwise I can release 1.1.2.

@cabol
Copy link
Owner

cabol commented Oct 31, 2020

Closing this issue, I think it is not necessary to make a new release because the version 0.11 of Redix will be fetched automatically (since it is defined as "~> 0.10"), it will be just a matter to update the dependencies.

@cabol cabol closed this as completed Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants