Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oncogenic archer fusion is not counted in the SV/Fusion Driver category #9309

Closed
zhx828 opened this issue Feb 15, 2022 · 2 comments · Fixed by cBioPortal/cbioportal-frontend#4196
Assignees
Labels

Comments

@onursumer
Copy link
Member

This is a data processing issue in the frontend.

The function generateAnnotateStructuralVariantQueryFromGenes relies on ids with undefined values due to the lack of site2EntrezGeneId for some SV data. This causes generation of duplicate ids. For example 2261_undefined and 2263_undefined.

Since we get unique query variants by id we lose the actual oncogenicity information for the example fusions above and conclude that they are not oncogenic. See https://github.com/cBioPortal/cbioportal-frontend/blob/18417bb334367bb765b816c38ba0faf69a5ca9c5/src/shared/lib/StoreUtils.ts#L878.

A potential fix is to find a better way to generate ids for SVs in the function generateQueryStructuralVariantId.

@onursumer
Copy link
Member

onursumer commented Mar 2, 2022

For example we have 13 SVs with the same id 2261_undefined:

SV_2261_undefined

Most of these alterations are actually duplicate but not all of them:

SV_2261_undefined_intragenicVSarcher

So, 2261_undefined is not a unique id for this data set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants