-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lint pre-commit hook and use babel-eslint #54
Conversation
Add lint to pre-commit hook. Ignore or fix all current lint issues. Use babel-eslint because some files had parse errors.
Just a reminder, we decided last week that since we are going to adopt TypeScript, eslint will not be compatible. We will have to adopt TSLint instead. |
@alisman yeah that's a good point about switching to tslint. We can choose to:
I do think we should make the changes soon, since we're going to have a lot more people working on the project. It's a tricky merge now, but it'll be a bigger pain further down the line. We can also decide not to enforce eslint at all, since we have codeclimate at least checking new changes. But I think it would be nicer to start out clean. |
We've added tslint. We're skipping eslint atm |
Reuse rule id when updating linear rules
Reuse rule id when updating linear rules
Reuse rule id when updating linear rules
Reuse rule id when updating linear rules
Reuse rule id when updating linear rules
Reuse rule id when updating linear rules
Reuse rule id when updating linear rules
Reuse rule id when updating linear rules
Reuse rule id when updating linear rules
Reuse rule id when updating linear rules
Reuse rule id when updating linear rules
Reuse rule id when updating linear rules
Reuse rule id when updating linear rules
Reuse rule id when updating linear rules
Reuse rule id when updating linear rules
Reuse rule id when updating linear rules
Add lint to pre-commit hook. Ignore or fix all current lint issues. Use
babel-eslint because some files had parse errors.