Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint pre-commit hook and use babel-eslint #54

Closed
wants to merge 1 commit into from

Conversation

inodb
Copy link
Member

@inodb inodb commented Oct 14, 2016

Add lint to pre-commit hook. Ignore or fix all current lint issues. Use
babel-eslint because some files had parse errors.

Add lint to pre-commit hook. Ignore or fix all current lint issues. Use
babel-eslint because some files had parse errors.
@alisman
Copy link
Collaborator

alisman commented Oct 14, 2016

Just a reminder, we decided last week that since we are going to adopt TypeScript, eslint will not be compatible. We will have to adopt TSLint instead.

@inodb
Copy link
Member Author

inodb commented Oct 14, 2016

@alisman yeah that's a good point about switching to tslint. We can choose to:

  1. switch all the files over to tsx, install tslint and call it a day
  2. have a period of having all jsx/js/ts and only make new files in typescript. In that case I would argue for having both eslint & tslint in place for a while

I do think we should make the changes soon, since we're going to have a lot more people working on the project. It's a tricky merge now, but it'll be a bigger pain further down the line.

We can also decide not to enforce eslint at all, since we have codeclimate at least checking new changes. But I think it would be nicer to start out clean.

@inodb
Copy link
Member Author

inodb commented Nov 2, 2016

We've added tslint. We're skipping eslint atm

@inodb inodb closed this Nov 2, 2016
onursumer added a commit to onursumer/cbioportal-frontend that referenced this pull request Dec 18, 2019
@inodb inodb deleted the fix-linting-errors branch January 11, 2022 22:55
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 11, 2022
Reuse rule id when updating linear rules
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 16, 2022
Reuse rule id when updating linear rules
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 18, 2022
Reuse rule id when updating linear rules
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 19, 2022
Reuse rule id when updating linear rules
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 20, 2022
Reuse rule id when updating linear rules
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 23, 2022
Reuse rule id when updating linear rules
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 24, 2022
Reuse rule id when updating linear rules
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 25, 2022
Reuse rule id when updating linear rules
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 26, 2022
Reuse rule id when updating linear rules
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 27, 2022
Reuse rule id when updating linear rules
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 27, 2022
Reuse rule id when updating linear rules
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request May 27, 2022
Reuse rule id when updating linear rules
alisman pushed a commit to alisman/cbioportal-frontend that referenced this pull request Jun 2, 2022
Reuse rule id when updating linear rules
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 6, 2022
Reuse rule id when updating linear rules
onursumer pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 6, 2022
Reuse rule id when updating linear rules
alisman pushed a commit to onursumer/cbioportal-frontend that referenced this pull request Jun 8, 2022
Reuse rule id when updating linear rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants