Study view km plot optimization

[dippindots]

Fix cBioPortal/cbioportal#9988
Fix cBioPortal/cbioportal#8378

Changes proposed in this pull request:

• Keep old implementation for comparison page/comparison tab survival plot

• Only apply binning when the sample size is larger than the threshold (default 1000, we can change this into a configurable value later)
  

• Logic for binning: flooring month to integer (e.g. flooring 100.2 or 100.4 to 100) and count any events or censored data that get aggregated

• Add information into tooltip to show the count for events and censored

Other comments:

• Change text in the tooltip:
  • Time of event: 46-47 months -> Events during [46,47) months. Use brackets/parenthesis notation here depending on how you are binning: https://stackoverflow.com/a/4396303
  • Patients with an event:
  • Censored patients:
  • Newline
  • % event free at end of months (46 months) -> % event free at interval end:
  • Patients at risk at interval end:
  • 
• Indicate in info icon that events were floored to the nearest month
• Indicate the unit for the x axis in the info icon

Follow-up ticket:

cBioPortal/icebox#483

[inodb]

Thanks @dippindots - this looks great!

Maybe a few tweaks to the text and ordering here:

• Time of event: 46-47 months -> Events during [46,47) months. Use brackets/parenthesis notation here depending on how you are binning: https://stackoverflow.com/a/4396303
• Patients with an event:
• Censored patients:
• Newline
• % event free at end of months (46 months) -> % event free at interval end:
• Patients at risk at interval end:

It might make sense to highlight the entire bin when mousing over (so one horizontal line). Currently, it highlights points and it's a little hard to see that it's showing an interval:

Additional comments from Niki:

• Can we indicate somewhere (maybe in info icon) that events were floored to the nearest month?
• Can we also indicate the unit for the x axis somewhere (also in the info icon)?

[tmazor]

This is great! I agree with all of Ino's comments above, and I also noticed that the tooltips will extend off the page:

Can you make the tooltips appear to the left of the chart when the chart is on the right side of the page, like pie charts do?

[alisman]

seems it would be simple enough to type this.

[alisman]

@dippindots can we type this?

[alisman]

@dippindots lets bring this up at standup today to figure out what's next.