Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop when study search query consists of single "or" #4394

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

BasLee
Copy link

@BasLee BasLee commented Oct 19, 2022

When entering 'or' in the study search field index page crashes due to an infinite loop.
This is because the search query parser interprets the 'or' as a separator between two search and-clauses (and no next search query can be found).
To fix this, the search query parser now interprets a single 'or' as a search term. This logic is also applied to search queries ending in a single or (e.g. 'tcga or').
Another solution would have been removing the trailing 'or', but this would also modify the search query shown in the search box, which is undesirable.

Testing

@alisman alisman merged commit 153a877 into cBioPortal:master Oct 19, 2022
@dippindots dippindots added the bug label Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants