Lollipop plots in group comparison page shows mutations for two or more groups #4392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20b4ea6 to
c2c5fe2
Compare
daf9f10 to
7f2cfe9
Compare
alisman
reviewed
Oct 25, 2022
packages/cbioportal-frontend-commons/src/components/SVGAxis.tsx
Outdated
Show resolved
Hide resolved
alisman
reviewed
Oct 25, 2022
packages/cbioportal-frontend-commons/src/components/SVGAxis.tsx
Outdated
Show resolved
Hide resolved
onursumer
requested changes
Oct 25, 2022
packages/react-mutation-mapper/src/component/lollipopPlot/LollipopPlotNoTooltip.tsx
Outdated
Show resolved
Hide resolved
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 25, 2022
alisman
reviewed
Oct 26, 2022
alisman
reviewed
Oct 26, 2022
alisman
reviewed
Oct 26, 2022
alisman
reviewed
Oct 26, 2022
alisman
reviewed
Oct 26, 2022
alisman
reviewed
Oct 26, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
| }); | ||
|
|
||
| readonly profiledSamplesCount = remoteData({ | ||
| await: () => [this.allSamples, this.coverageInformation], |
There was a problem hiding this comment.
@inodb @onursumer i don't understand why the denominator is all samples here. that's all samples in ALL studies which are present here.
There was a problem hiding this comment.
I think the idea here is to display the frequency of this mutation in the entire cohort. So, we need to find all samples profiled for this gene.
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
alisman
reviewed
Nov 2, 2022
added 3 commits
November 3, 2022 12:38
onursumer
requested changes
Nov 7, 2022
packages/react-mutation-mapper/src/component/lollipopPlot/LollipopPlotNoTooltip.tsx
Outdated
Show resolved
Hide resolved
src/pages/staticPages/tools/mutationMapper/MutationMapperToolStore.ts
Outdated
Show resolved
Hide resolved
| @@ -1060,6 +1068,24 @@ export default abstract class ComparisonStore | |||
| }, | |||
| }); | |||
|
|
|||
| @computed get genesWithMaxFrequency(): AlterationEnrichmentRow[] { | |||
There was a problem hiding this comment.
This is taken from another incomplete PR, but I think the function name is not ideal. We are returning an array of AlterationEnrichmentRow and calling it genesWithMaxFrequency
This was referenced Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement issue cBioPortal/GSoC#88