Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sleep command for local e2e test #4373

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Update sleep command for local e2e test #4373

merged 1 commit into from
Sep 15, 2022

Conversation

dippindots
Copy link
Member

@dippindots dippindots commented Sep 14, 2022 •
edited
Loading

When I work with @gblaih, we found that yarn run e2e:spinup works on my laptop but not his.
Finally we found that different MacOS has different support for sleep command (e.g. some system doesn't support sleep 5s but support sleep 5).
The temporary solution is to change every sleep commands used in yarn run e2e:spinup to sleep x

ideally we should

@dippindots dippindots mentioned this pull request Sep 14, 2022
Open
@dippindots dippindots marked this pull request as ready for review September 14, 2022 18:27
@dippindots dippindots requested a review from inodb September 14, 2022 21:09
@alisman alisman merged commit 74603a6 into cBioPortal:master Sep 15, 2022
@dippindots dippindots deleted the update-e2e-sign-up branch September 16, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gblaih gblaih gblaih approved these changes

@alisman alisman Awaiting requested review from alisman

@inodb inodb Awaiting requested review from inodb

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dippindots @gblaih @alisman