Oncoprint tracks menu: move groups and charts to top level #4368
Conversation
| !this.options.isComplete || | ||
| this.options.result!.clinical.length === 0 | ||
| !this.props.options.isComplete || | ||
| this.props.options.result!.clinical.length === 0 | ||
| } | ||
| > | ||
| {this.addClinicalTracksMenu.component} | ||
| </MSKTab> | ||
| <MSKTab |
There was a problem hiding this comment.
So, this is what I was looking for. There is still a possibility that there will be more than one tab because of the custom charts tab. Thus, we need to keep the menu. I see that we are already hiding the menu when there is only one option, so it seems like no change is necessary here. (If there was only ever a single tab, it would make sense to just get rid of the tab structure altogether).
| showLastRenderWhenPending: true, | ||
| }); | ||
|
|
||
| readonly options = remoteData({ |
There was a problem hiding this comment.
I think this name could be improved (i realize it was existing). It's really track options by type. "trackOptionsByType" ?
| onAddAll: (keys: string[]) => void; | ||
| onClearAll: (keys: string[]) => void; | ||
| onToggleOption: (key: string) => void; | ||
| selectedClinicalAttributeIds: Dictionary<string>; |
There was a problem hiding this comment.
see if you can use the Typescript Record type instead of this lodash supplied type.
There was a problem hiding this comment.
i mean, continue to use _.keyBy, that's correct, but see if you change the typing of this propery to Record if it will work. Record is generic so you'll have to supply the key and value types, e.g. Record<string,string>
|
@gblaih we need to fix the following, where there is now only one subtab tab visible in clinical tab, we shouldn't show the sub tabs at all. that logic was actually working before, but something about changes seems to have broken it.
|
188e36b to
a05d8da
Compare
a05d8da to
c8da21c
Compare
Fix issue cBioPortal/cbioportal#9789