Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix results view generic assay oncoprint selection issue #4284

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Fix results view generic assay oncoprint selection issue #4284

merged 2 commits into from
Jun 6, 2022

Conversation

dippindots
Copy link
Member

@dippindots dippindots commented Jun 3, 2022 •
edited
Loading

Fix cBioPortal/cbioportal#9591

  • Update a potential bug that may make the selection and oncoprint track update out of sync
  • Update test scripts. We need to update test scripts because we didn’t select any profiles in the scripts, which we should. Because profiles order are likely to change when importing a study, if we don’t make a selection, we will get similar errors in the future.

@dippindots dippindots force-pushed the fix-9591 branch 3 times, most recently from 01610fe to 92c50fd Compare June 6, 2022 14:47
@dippindots dippindots requested a review from alisman June 6, 2022 17:04
@dippindots dippindots marked this pull request as ready for review June 6, 2022 17:57
@alisman alisman merged commit 5382ab1 into cBioPortal:master Jun 6, 2022
@dippindots dippindots changed the title fix result generic assay oncoprint issue Fix results view generic assay oncoprint selection issue Jun 6, 2022
@dippindots dippindots added the bug label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisman alisman alisman approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with generic assay track add
2 participants
@dippindots @alisman