Update unit test yarn scripts and add grepping ability #4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
commented
May 26, 2022
| @@ -27,7 +27,7 @@ | |||
| "tcm": "tcm -p src/**/*.module.scss", | |||
| "tcm:watch": "yarn run tcm --watch", | |||
| "prepare": "yarn run build", | |||
| "test": "cross-env jest --env=jsdom --runInBand --ci --reporters=default --reporters=jest-junit", | |||
| "test": "cross-env jest $GREP --env=jsdom --runInBand --ci --reporters=default --reporters=jest-junit --passWithNoTests", | |||
There was a problem hiding this comment.
these pass with no tests needed to be added in order to support GREP because there will be no matches there.
onursumer
reviewed
May 26, 2022
| @@ -27,7 +27,7 @@ | |||
| "tcm": "tcm -p src/**/*.module.scss", | |||
| "tcm:watch": "yarn run tcm --watch", | |||
| "prepare": "yarn run build", | |||
| "test": "cross-env CI=1 jest --env=jsdom --runInBand --passWithNoTests", | |||
| "test": "cross-env CI=1 jest $GREP --env=jsdom --runInBand --passWithNoTests", | |||
There was a problem hiding this comment.
Why don't we use the same script here? Is it because this package has no test cases?
Suggested change
| "test": "cross-env CI=1 jest $GREP --env=jsdom --runInBand --passWithNoTests", | |
| "test": "cross-env jest $GREP --env=jsdom --runInBand --ci --reporters=default --reporters=jest-junit --passWithNoTests", |
There was a problem hiding this comment.
oh, yeah, i didn't bother putting in packages that didn't have tests. but i guess this one COUNT have tests. so that's a good point.
| "check-env": "echo ", | ||
| "testMain": "jest $GREP --env=jsdom --runInBand --ci --reporters=default --reporters=jest-junit", | ||
| "testPackagesCI": "JEST_JUNIT_UNIQUE_OUTPUT_NAME=true JEST_JUNIT_OUTPUT_DIR=/tmp/junit/module/ JEST_JUNIT_OUTPUT_NAME=unit-test-module yarn run testPackages", | ||
| "testPackages": "lerna run test --ignore=cbioportal-frontend --stream", |
There was a problem hiding this comment.
Hmm. We should probably rename buildModules and publishModules as well for consistency. In that case we will also need to update https://github.com/cBioPortal/cbioportal-publisher/blob/master/.github/workflows/cbioportal-frontend-publish.yml#L27-L28.
onursumer
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have two different unit testing jobs and dev scripts needed to reflect that. README as well.