Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jest junit reporting and unit test circular reference #4269

Merged
merged 2 commits into from
May 26, 2022
Merged

Fix jest junit reporting and unit test circular reference #4269

merged 2 commits into from
May 26, 2022

Conversation

alisman
Copy link
Collaborator

@alisman alisman commented May 20, 2022 •
edited
Loading

There were a number of problems with unit test

  1. We were not outputting junit reports for circleci to interpret
  2. Running two jest jobs in one command seemed problematic
  3. There was a circular dependency which seemed to be causing jest to crash/tests to fail

@alisman alisman force-pushed the fixunit branch 6 times, most recently from eb0801b to fb05c04 Compare May 24, 2022 19:38
@alisman alisman changed the title Only run testmain Fix jest junit reporting and unit test circular reference May 24, 2022
@alisman alisman requested a review from Luke-Sikina May 24, 2022 19:57
Luke-Sikina
Luke-Sikina approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@Luke-Sikina Luke-Sikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending passing tests

@alisman alisman merged commit 12ad2d8 into cBioPortal:master May 26, 2022
@alisman alisman deleted the fixunit branch May 26, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luke-Sikina Luke-Sikina Luke-Sikina approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alisman @Luke-Sikina